fix: provide updated manual deposit for both ETH and non-ETH chains #1808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mm-zk
reviewed
Apr 26, 2024
kelemeno
reviewed
Apr 26, 2024
kelemeno
reviewed
Apr 26, 2024
kelemeno
previously approved these changes
Apr 26, 2024
kelemeno
approved these changes
Apr 29, 2024
ly0va
approved these changes
Apr 29, 2024
Deniallugo
pushed a commit
that referenced
this pull request
May 7, 2024
…1808) ## What ❔ Updated manual deposit for rich accounts to account for Bridgehub changes. Added support for non-ETH based chains. ## Why ❔ Old API is no longer supported by the bridgehub. ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [x] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [x] Code has been formatted via `zk fmt` and `zk lint`. - [ ] Spellcheck has been run via `zk spellcheck`. - [ ] Linkcheck has been run via `zk linkcheck`. --------- Co-authored-by: Raid Ateir <ra@matterlabs.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Updated manual deposit for rich accounts to account for Bridgehub changes.
Added support for non-ETH based chains.
Why ❔
Old API is no longer supported by the bridgehub.
Checklist
zk fmtandzk lint.zk spellcheck.zk linkcheck.