feat: make more structs serializable

[haraldh]

What ❔

Make more structs serializable.

Why ❔

Needed for the TEE verifier as input. These structs will be serialized for intercloud data exchange.

Checklist

• PR title corresponds to the body of PR (we generate changelog entries from PRs).
• Tests for the changes have been added / updated.
• Documentation comments have been added / updated.
• Code has been formatted via zk fmt and zk lint.
• Spellcheck has been run via zk spellcheck.
• Linkcheck has been run via zk linkcheck.

[haraldh]

Failed linkcheck action fixed with #1720

[mm-zk]

is there any reason for this?
Every struct that is serializable, makes it harder to do breaking changes to (for example, if I'm adding or removing the field, now i have to look to make sure that I didn't break the serialization)

[haraldh]

is there any reason for this? Every struct that is serializable, makes it harder to do breaking changes to (for example, if I'm adding or removing the field, now i have to look to make sure that I didn't break the serialization)

@mm-zk while I agree with you, it will be needed for an external running (SGX) verifier ... do you have any other suggestion on how to solve this? Either we will have to have a public constructor for those structs, or do it via serde.

[haraldh]

Or we can state, that the serialization user is aware of struct changes and can cope with those by making sure the consumer is in lockstep with the producer.

[mm-zk]

@haraldh - what do you mean by 'public constructor'? AFAIK in rust as long as all the fields are pub, you have implicit public constructor (Struct{field1: xx, field2: yy} )

[haraldh]

@haraldh - what do you mean by 'public constructor'? AFAIK in rust as long as all the fields are pub, you have implicit public constructor (Struct{field1: xx, field2: yy} )

True, in this case all the fields of the touched structs are public. So, we will have to make shadow structs for all of them instead, if this PR is not gonna make it.

[mm-zk]

@haraldh - what do you mean by 'shadow structs'?

and do you actually serialize these objects as strings?

[haraldh]

@haraldh - what do you mean by 'shadow structs'?

as you could see in #1860

Adding Serialize, Deserialize results in removing the shadow structs, see the core/lib/tee_verifier/src/lib.rs changes in this commit

and do you actually serialize these objects as strings?

No... bincode