Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debugger panel improvements #34

Merged
merged 6 commits into from
Jan 31, 2024
Merged

Debugger panel improvements #34

merged 6 commits into from
Jan 31, 2024

Conversation

jackTabsCode
Copy link
Contributor

@jackTabsCode jackTabsCode commented Jan 31, 2024 •
edited
Loading

This PR includes improvements to the debugger panel, in specific the systems section:

  • Bars under the systems indicating their duration relative to the longest system. A full bar means this system is taking the most time (but doesn't necessarily mean it's not performant).
  • Index to the left of the system name for improved visual grepping
  • Panel slightly wider to accodomate the index element

Also a minor font change in an unrelated file is included since I forgot it in my last style PR.

RobloxStudioBeta_mcQF7dZ6Zq

@jackTabsCode jackTabsCode requested a review from a team January 31, 2024 20:09
benbrimeyer
benbrimeyer reviewed Jan 31, 2024
View reviewed changes
lib/debugger/widgets/selectionList.lua Outdated Show resolved Hide resolved
lib/debugger/widgets/selectionList.lua Outdated Show resolved Hide resolved
lib/debugger/widgets/selectionList.lua Outdated Show resolved Hide resolved
lib/debugger/ui.lua Show resolved Hide resolved
jackTabsCode and others added 3 commits January 31, 2024 12:43
@jackTabsCode @benbrimeyer
Update lib/debugger/widgets/selectionList.lua
55e280b 
Co-authored-by: benj <benjaminbrimeyer@gmail.com>
@jackTabsCode @benbrimeyer
Update lib/debugger/widgets/selectionList.lua
78ed199 
Co-authored-by: benj <benjaminbrimeyer@gmail.com>
@jackTabsCode @benbrimeyer
Update lib/debugger/widgets/selectionList.lua
cf62224 
Co-authored-by: benj <benjaminbrimeyer@gmail.com>
LastTalon
LastTalon approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@LastTalon LastTalon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackTabsCode jackTabsCode merged commit 95c6262 into main Jan 31, 2024
6 checks passed
@jackTabsCode jackTabsCode deleted the debugger-duration-bars branch January 31, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benbrimeyer benbrimeyer benbrimeyer left review comments

@LastTalon LastTalon LastTalon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jackTabsCode @LastTalon @benbrimeyer