remove client.address as default attribute on RPC metrics (grafana#1022)

mattdurham · Jul 16, 2024 · 33af474 · 33af474
1 parent b0fba9c
commit 33af474
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/pkg/internal/export/attributes/attr_defs.go b/pkg/internal/export/attributes/attr_defs.go
@@ -236,9 +236,6 @@ func getDefinitions(groups AttrGroups) map[Section]AttrReportGroup {
 				attr.RPCMethod:         true,
 				attr.RPCSystem:         true,
 				attr.RPCGRPCStatusCode: true,
-				// Overriding default serverInfo configuration because we want
-				// to report it by default
-				attr.ClientAddr: true,
 			},
 		},
 		DBClientDuration.Section: {

diff --git a/pkg/internal/pipe/instrumenter_test.go b/pkg/internal/pipe/instrumenter_test.go
@@ -44,7 +44,7 @@ func gctx(groups attributes.AttrGroups) *global.ContextInfo {
 }
 
 var allMetrics = attributes.Selection{
-	attributes.HTTPServerDuration.Section: attributes.InclusionLists{Include: []string{"*"}},
+	"*": attributes.InclusionLists{Include: []string{"*"}},
 }
 
 func allMetricsBut(patterns ...string) attributes.Selection {