add support for NHL leagues #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattdodge
reviewed
Dec 20, 2022
yahoofantasy/__init__.py
Outdated
| @@ -7,4 +7,5 @@ | |||
| from .resources.week import Week # noqa: F401 | |||
| from .stats.stat import Stat # noqa: F401 | |||
|
|
|||
| __version__ = "1.3.1" | |||
| __version__ = "1.3.2" | |||
There was a problem hiding this comment.
You can remove this version bump from this PR. I will run the version upgrade manually after it's merged. It would be a minor release (1.4.0) vs a patch release (1.3.2) anyway, since this is all new functionality
There was a problem hiding this comment.
made these changes, also made some more in the README now that all of the sports are supported 🥳
b428626 to
d94e7cc
Compare
d94e7cc to
58c8eff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested this locally and was able to get information about my NHL league