-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add policies for memorydb #291
Conversation
80b0ff0
to
dbd1988
Compare
You should also add All the classes, except that one that has create_time property, should subclass DbTerminator rather than Terminator. |
I'm still testing, but you should also apply the changes we have suggested during the triage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GomathiselviS I added some new suggestions for some functions, but I would like to see @gravesm opinion's first.
The better way to handle cases where some resource can't be deleted until another resource is deleted is to use |
Can be tested with this one ansible-collections/amazon.cloud#120 too. |
Add policies for memorydb
The testcases in the PR fails because of permission issues. This PR adds the missing permissions to execute the memorydb testcases.