Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add policies for memorydb #291

Merged
merged 11 commits into from
Aug 28, 2023
Merged

Conversation

GomathiselviS
Copy link
Contributor

@GomathiselviS GomathiselviS commented Aug 11, 2023

Add policies for memorydb

The testcases in the PR fails because of permission issues. This PR adds the missing permissions to execute the memorydb testcases.

@alinabuzachis
Copy link
Collaborator

alinabuzachis commented Aug 17, 2023

You should also add - 'arn:aws:iam::{{ aws_account_id }}:role/aws-service-role/memorydb.amazonaws.com/*' to https://github.com/mattclay/aws-terminator/blob/main/aws/policy/security-services.yaml#L177 and - 'memorydb.amazonaws.com'to https://github.com/mattclay/aws-terminator/blob/main/aws/policy/security-services.yaml#L188

All the classes, except that one that has create_time property, should subclass DbTerminator rather than Terminator.

@alinabuzachis
Copy link
Collaborator

I'm still testing, but you should also apply the changes we have suggested during the triage.

Copy link
Collaborator

@alinabuzachis alinabuzachis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GomathiselviS I added some new suggestions for some functions, but I would like to see @gravesm opinion's first.

@gravesm
Copy link
Collaborator

gravesm commented Aug 22, 2023

The better way to handle cases where some resource can't be deleted until another resource is deleted is to use age_limit. The AWS docs don't really describe the circumstances under which the various exceptions are raised. While SubnetUseInGroup seems pretty descriptive, InvalidUserStateFault sounds kind of generic.

@alinabuzachis
Copy link
Collaborator

Can be tested with this one ansible-collections/amazon.cloud#120 too.

@alinabuzachis alinabuzachis requested a review from gravesm August 25, 2023 17:24
@alinabuzachis alinabuzachis merged commit 0d38eeb into mattclay:main Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants