Add Open Button For Chosen Fluidity Entity Picker #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
prjseal
commented
Apr 29, 2018
- added support for opening a chosen record using the fluidity entity picker
|
This is related to this issue. #43 |
|
Here is what it will look like |
mattbrailsford
requested changes
Apr 29, 2018
| @@ -84,6 +84,11 @@ | |||
| angularHelper.getCurrentForm($scope).$setDirty(); | |||
| }; | |||
|
|
|||
| $scope.open = function (section, collection, id) { | |||
| var openHref = "/umbraco/#/" + section + "/fluidity/edit/" + collection + "!" + id; | |||
| window.location.href = openHref; | |||
There was a problem hiding this comment.
Need to use the $location service and call $location.path(/section/fluidity/edit/collection!id) instead of changing the window location explicitly as that's the angular way to do it. By changing it via window you are requiring the need of /umbraco/ in the route which could break if someone changes this (it's possible to change in config).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.