Cannot save an entity when fireEvents is set to false.

[JimBobSquarePants]

using .Save(object, false) against the current master branch.

https://github.com/umco/umbraco-fluidity/blob/04feb1d4b83ccc33bb2d03e7a3d29dd01b731d65/src/Fluidity/Data/DefaultFluidityRepository.cs#L135

The code sets the args to null on line 113 but then tries to access a property on that reference.

      public object Save(object entity, bool fireEvents = true)
        {
            // I AM NULL
            SavingEntityEventArgs args = null;

            if (fireEvents)
            {
                var existing = Get(entity.GetPropertyValue(_collection.IdProperty));
               
                // I AM ONLY SET HERE
                args = new SavingEntityEventArgs
                {
                    Entity = new BeforeAndAfter<object>
                    {
                        Before = existing,
                        After = entity
                    }
                };

                Fluidity.OnSavingEntity(args);

                if (args.Cancel)
                    return args.Entity.After;

                entity = args.Entity.After;
            }

            // I AM NULL HERE!
            Db.Save(args.Entity.After);

            if (fireEvents)
            {
                Fluidity.OnSavedEntity(args);

                entity = args.Entity.After;
            }

            return entity;
        }

[mattbrailsford]

Good spot. I should be calling save on the entity variable not the one in the event args. I've pushed a fix and should be available in the nightly shortly.

[JimBobSquarePants]

Nice one, thanks! 😄