Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub action runner OS not set #114

Closed
wsdewitt opened this issue Apr 24, 2023 · 0 comments
Closed

GitHub action runner OS not set #114

wsdewitt opened this issue Apr 24, 2023 · 0 comments

Comments

@wsdewitt
Copy link
Collaborator

wsdewitt commented Apr 24, 2023

The matrix for this build/test workflow specifies ubuntu and macos, but the first line hard codes the runner to be ubuntu.

runs-on: ubuntu-latest
strategy:
matrix:
os: [ubuntu-latest, macos-latest]
python-version: [3.7, 3.8, 3.9]

I think we want to replace to something like:

    strategy:
      matrix:
        os: [ubuntu-latest, macos-latest]
        python-version: [3.7, 3.8, 3.9]
    runs-on: ${{ matrix.os }}

Or if running only on ubuntu was intended, we can remove macos from the matrix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant