Move /createRoom to the event_creator worker #1128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0099467 to
7b6a4d3
Compare
I think I understand the problem. We're fetching which is an ancient commit from https://github.com/matrix-org/synapse/tree/matthew/fix-roomdir-pagination that doesn't contain the blacklist file. We want to fetch Will have to see what the right invocation is here. But it's not |
|
Looks like @clokep has done the hard work for us already. |
erikjohnston
approved these changes
Sep 6, 2021
DMRobertson
pushed a commit
that referenced
this pull request
Sep 8, 2021
In #1115 I didn't correctly handle the situation where there's a corresponding synapse/dendrite branch to fetch. #1128 fell victim to this. Fix: reuse the shell script from matrix-org/synapse#10160, i.e. consult a wider range of GHA's environment variables. Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tests that
/createRoomactually works on workers, which turns out is only true after matrix-org/synapse#10757 lands.Thus this PR shares a branch name with that PR.
The failing tests are a bug with the GHA runs, but buildkite should be passing!