Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Kill off deprecated "config-on-the-fly" docker mode #6918

Merged
merged 3 commits into from
Feb 18, 2020
Merged

Kill off deprecated "config-on-the-fly" docker mode #6918

merged 3 commits into from
Feb 18, 2020

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Feb 14, 2020

Lots of people seem to get confused by this mode, and it's been deprecated
since Synapse 1.1.0. It's time for it to go.

Fixes #6912

@richvdh
Kill off deprecated "config-on-the-fly" docker mode
41395e8 
Lots of people seem to get confused by this mode, and it's been deprecated
since Synapse 1.1.0. It's time for it to go.
@richvdh richvdh requested a review from a team February 14, 2020 13:14
richvdh
richvdh commented Feb 14, 2020
View reviewed changes
docker/start.py
@@ -188,11 +188,6 @@ def main(args, environ):
else:
ownership = "{}:{}".format(desired_uid, desired_gid)

log(
Copy link
Member Author

@richvdh richvdh Feb 14, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed this while I was here because it looked misleadingly like an error message, and I'm not sure what it was for (possibly debug?)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember there being a problem with uid's in docker that a fix came in for. This was possibly debugging for it. Considering I haven't heard anyone speak of this problem for a while, it's probably unnecessary logging at this point.

anoadragon453
anoadragon453 approved these changes Feb 17, 2020
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm other than the nit below

docker/start.py
@@ -188,11 +188,6 @@ def main(args, environ):
else:
ownership = "{}:{}".format(desired_uid, desired_gid)

log(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember there being a problem with uid's in docker that a fix came in for. This was possibly debugging for it. Considering I haven't heard anyone speak of this problem for a while, it's probably unnecessary logging at this point.

docker/start.py Outdated Show resolved Hide resolved
@richvdh @anoadragon453
Update docker/start.py
7846384 
Co-Authored-By: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
@richvdh
Copy link
Member Author

richvdh commented Feb 18, 2020

sytest is now failing due to unrelated changes on develop. merging anyway.

@richvdh richvdh merged commit 3be2abd into develop Feb 18, 2020
@richvdh richvdh deleted the rav/kill_docker_fallback_mode branch February 18, 2020 11:41
babolivier pushed a commit that referenced this pull request Sep 1, 2021
@anoadragon453
Kill off deprecated "config-on-the-fly" docker mode (#6918)
44b314b 
* commit '3be2abd0a':
  Kill off deprecated "config-on-the-fly" docker mode (#6918)
  #6924 has been released in 1.10.1
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anoadragon453 anoadragon453 anoadragon453 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richvdh @anoadragon453