This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Limit the number of devices we delete at once #14649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f249a2f to
99eadb2
Compare
reivilibre
approved these changes
Dec 9, 2022
DMRobertson
reviewed
Dec 9, 2022
Comment on lines
-1617
to
+1621
| SELECT DISTINCT device_id FROM devices | ||
| SELECT device_id FROM devices |
There was a problem hiding this comment.
Why no longer DISTINCT?
There was a problem hiding this comment.
oh, presumably (user_id, device_id) is already unique
There was a problem hiding this comment.
It was pointless mostly, as there are unique indexes on user_id / device_id
MatMaul
approved these changes
Dec 9, 2022
reivilibre
added a commit
that referenced
this pull request
Dec 12, 2022
This reverts commit 94bc21e.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on from #14595