Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix bug in StateFilter.return_expanded() and add some tests. #12016

Merged
merged 4 commits into from
Feb 18, 2022
Merged

Fix bug in StateFilter.return_expanded() and add some tests. #12016

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a5fb58c
Add tests for StateFilter.return_expanded
reivilibre Feb 17, 2022
ed84367
Fix StateFilter.return_expanded when Member type is absent and includ…
reivilibre Feb 17, 2022
85380c4
Newsfile
reivilibre Feb 17, 2022
de8ca24
Add test for wildcard member-only state filters
reivilibre Feb 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tests/storage/test_state.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1050,14 +1050,14 @@ def test_return_expanded(self):
),
)

# Member-only state filters stay the same
# Wildcard member-only state filters stay the same
self.assertEqual(
StateFilter.freeze(
{EventTypes.Member: {"@wombat:test", "@alicia:test"}},
{EventTypes.Member: None},
include_others=False,
).return_expanded(),
StateFilter.freeze(
{EventTypes.Member: {"@wombat:test", "@alicia:test"}},
{EventTypes.Member: None},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks---though I think both of these test cases are worth having?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test case just before was a dupe unless I misread.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes, right you are.

include_others=False,
),
)
Expand Down