This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Prevent local user profiles leaking when a "per-room profile" is changed#10695

Closed

DMRobertson wants to merge 48 commits intodevelopfrom dmr/user-directory-nickname-leaks

+410-278

Commits on Aug 31, 2021

Fix passing None to DB helpers
David Robertson
committed
Misc refactors
David Robertson
committed
changelog stub
David Robertson
committed
Docstrings, method reorder and rename
David Robertson
committed
Always load local users into user_directory
David Robertson
committed
Remove unnecessary set() construction
David Robertson
committed
Only update remote users dir. entries from events
David Robertson
committed
Refactor to remove a level of indentation
David Robertson
committed
test_profile: register a user, not just a profile
David Robertson
committed
Use test-level "register_user", not the store
David Robertson
committed
Missed an await GRR
David Robertson
committed

Commits on Sep 1, 2021

Register user in RoomJoinRatelimitTestCase
David Robertson
committed
Need the admin servlet to register_user
David Robertson
committed
Fix test: handler assumes lowercase username
David Robertson
committed
Grrrrrr lint
David Robertson
committed

Commits on Sep 2, 2021

Rename to clarify local versus remote name changes
David Robertson
committed
Don't leak local users' per-room names on join
David Robertson
committed
Update synapse/handlers/user_directory.py

David Robertson
and
reivilibre
authored
Changelog
David Robertson
committed
Method rename again
David Robertson
committed
Pull out the loop from _handle_deltas
David Robertson
committed
Exclude support users early
David Robertson
committed
Exclude events from app_services users early
David Robertson
committed
Handle joined is MatchChange.now_false in 1 spot
David Robertson
committed
Test case for making a room public
David Robertson
committed
Remove redundant comment
David Robertson
committed
Only remove remote users from dir
David Robertson
committed
Split apart _handle_add_user
David Robertson
committed
Lint
David Robertson
committed
Linttttttt
David Robertson
committed

Commits on Sep 3, 2021

Remove unused arg from rem. profile change handler
David Robertson
committed
Inline remote user joining room
David Robertson
committed
Comment where we still have work TODO
David Robertson
committed
Typing in storage module for user_directory
David Robertson
committed
Comments about leakages
David Robertson
committed
db user dir: pull out processing a room to method
David Robertson
committed
Exit early if process_single_room if not in room
David Robertson
committed
Describe data model in docs
David Robertson
committed
Additional comments on the bg process
David Robertson
committed
Linttttttt
David Robertson
committed
Update changelog
David Robertson
committed
Rationale for synapse test, not complement
David Robertson
committed
Oliver's suggestions from code review.

David Robertson
and
reivilibre
authored
Fixup docs as per review
David Robertson
committed
Fix coment and extra check, as per review
David Robertson
committed
Improve docstring for _handle_remove_user
David Robertson
committed

Commits on Sep 8, 2021

Fix reactivated users not being added to directory (#10762 )

David Robertson
and
dklimpel
authored
Revert "Fix reactivated users not being added to directory (#10762 )"
David Robertson
committed