Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using simplejson. #60

Merged
merged 8 commits into from
Mar 14, 2023
Merged

Stop using simplejson. #60

merged 8 commits into from
Mar 14, 2023

Conversation

clokep
Copy link
Member

@clokep clokep commented Mar 14, 2023 •
edited
Loading

We can simplify a lot if we drop support for simplejson. Based on #59, which is already a breaking change.

Base automatically changed from dmr/decouple-frozendict to main March 14, 2023 19:32
@clokep clokep marked this pull request as ready for review March 14, 2023 20:00
@clokep clokep requested a review from a team as a code owner March 14, 2023 20:00
DMRobertson
DMRobertson approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@clokep clokep merged commit 95b6ec7 into main Mar 14, 2023
@clokep clokep deleted the clokep/no-simplejson branch March 14, 2023 21:12
@jobh jobh mentioned this pull request Dec 12, 2024
Closed
@richvdh richvdh linked an issue Dec 12, 2024 that may be closed by this pull request
Remove simplejson dependency #23
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DMRobertson DMRobertson DMRobertson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove simplejson dependency
2 participants
@clokep @DMRobertson