Make iconv dependency optional again. #51
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although iconv is listed in optionalDependencies, it's always required in Client.prototype.convertEncoding function in lib/irc.js file, even if neither "encoding" nor "encodingFallback" options are defined. This error was introduced in 19daa5b when require('iconv') was erroneously moved to the top of that function to avoid code duplication. This change makes iconv module not required again when encoding and encodingFallback options are not defined. Signed-off-by: Oleg Girko <ol@infoserver.lv>
|
We've instead moved to something that doesn't require native compilation which will hopefully help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although
iconvis listed inoptionalDependencies, it's always required inClient.prototype.convertEncodingfunction inlib/irc.jsfile, even if neitherencodingnorencodingFallbackoptions are defined.This error was introduced in 19daa5b when
require('iconv')was erroneously moved to the top of that function to avoid code duplication.This change makes
iconvmodule not required again whenencodingandencodingFallbackoptions are not defined.