Improve documentation on how Transactions work #1461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The response is based upon various sections of the Synapse code in how it generates a response. There are no new fields added to the transaction. Originally, `previous_ids` and `pdu_failures` were to be documented however neither of these are used in the real world.
turt2live
commented
Jul 30, 2018
| type: object | ||
| description: |- | ||
| The PDUs from the original transaction. The string key represents the ID of the | ||
| PDU (event) that was processed. |
There was a problem hiding this comment.
Something to consider: we could shorten the response size for massive transactions by assuming that an event not listed here was successfully processed. Synapse and Dendrite both don't seem to care about successful events from the response.
There was a problem hiding this comment.
Yup. Though I'm not sure its really worth it, especially if we start limiting the number of pdus per transaction.
There was a problem hiding this comment.
yea, limiting transaction sizes would be a better solution all around.
35 tasks
erikjohnston
approved these changes
Aug 3, 2018
RiotTranslateBot
pushed a commit
to RiotTranslateBot/matrix-doc
that referenced
this pull request
Aug 22, 2023
* Move Push Rules section out from Client Behaviour. * Clarify server vs. client behavior. * Remove references to unencrypted content.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered: see 'docs' commit status
The response is based upon various sections of the Synapse code in how it generates a response.
There are no new fields added to the transaction. Originally,
previous_idsandpdu_failureswere to be documented however neither of these are used in the real world.