Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(store-encryption): Remove an unwrap that snuck in #4506

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

poljar
Copy link
Contributor

@poljar poljar commented Jan 10, 2025

Found during my crusade against unwraps in the codebase.

@poljar poljar requested a review from a team as a code owner January 10, 2025 12:45
@poljar poljar requested review from andybalaam and removed request for a team January 10, 2025 12:45
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.36%. Comparing base (cb72d43) to head (8ada51e).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4506      +/-   ##
==========================================
- Coverage   85.37%   85.36%   -0.01%     
==========================================
  Files         284      284              
  Lines       31885    31885              
==========================================
- Hits        27222    27220       -2     
- Misses       4663     4665       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@poljar poljar merged commit def4bbb into main Jan 10, 2025
39 of 40 checks passed
@poljar poljar deleted the poljar/remove-unwrap-store-encryption branch January 10, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants