clippy: disallow useless asyncs
#3513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also don't tell damir but i've sneaked in a few test_ prefixes
because of our way to implement the trait only on wasm
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3513 +/- ##
==========================================
+ Coverage 83.75% 83.77% +0.01%
==========================================
Files 254 254
Lines 25729 25723 -6
==========================================
Hits 21550 21550
+ Misses 4179 4173 -6 ☔ View full report in Codecov by Sentry. |
cf2e0f0 to
515b3c9
Compare
|
Oh that's a nice lint! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using async when not required will increase compile times, and propagate async-ness to the callers, transitively.
See also the lint description.
Since we only had a few false positives, I've enabled it by default. This PR is supposed to be squashed-and-merged, there's no point in keeping the individual commits, but these should help with the review.
(Note there's a renaming in the middle too.)