Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Device manager - data fetching (PSG-637) #9151

Merged
merged 8 commits into from
Aug 10, 2022
Merged

Device manager - data fetching (PSG-637) #9151

merged 8 commits into from
Aug 10, 2022

Conversation

kerryarchibald
Copy link
Contributor

@kerryarchibald kerryarchibald commented Aug 8, 2022 •
edited by github-actions bot
Loading

  • extracts fetching logic into useOwnDevices hook
  • combines device and verification status into one interface as DeviceWithVerification
  • adds verified metadata to DeviceTile
  • adds current session section to new session manager screen

Existing UI, with new 'verified' metadata
Screenshot 2022-08-08 at 16 58 02

New session manager (behind labs flag):
Screenshot 2022-08-08 at 17 14 33

Notes: Device manager - data fetching

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@kerryarchibald kerryarchibald added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Aug 8, 2022
@kerryarchibald kerryarchibald changed the title Device manager - data fetching (PSG-636) Device manager - data fetching (PSG-637) Aug 8, 2022
@kerryarchibald kerryarchibald mentioned this pull request Aug 9, 2022
Merged
3 tasks
@kerryarchibald kerryarchibald force-pushed the psg-636/device-man-fetch-data branch from 23e3a40 to 6b2699b Compare August 9, 2022 08:18
@kerryarchibald kerryarchibald marked this pull request as ready for review August 9, 2022 08:20
@kerryarchibald kerryarchibald requested a review from a team as a code owner August 9, 2022 08:20
@kerryarchibald kerryarchibald mentioned this pull request Aug 9, 2022
Merged
3 tasks
@kerryarchibald kerryarchibald force-pushed the psg-636/device-man-fetch-data branch from 6b2699b to ad5b66d Compare August 9, 2022 13:14
@kerryarchibald kerryarchibald mentioned this pull request Aug 9, 2022
Merged
3 tasks
@kerryarchibald kerryarchibald force-pushed the psg-636/device-man-fetch-data branch from ad5b66d to 629d616 Compare August 10, 2022 14:34
germain-gg
germain-gg approved these changes Aug 10, 2022
View reviewed changes
Copy link
Contributor

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@kerryarchibald kerryarchibald mentioned this pull request Aug 10, 2022
Merged
3 tasks
@kerryarchibald kerryarchibald merged commit b7872f2 into develop Aug 10, 2022
@kerryarchibald kerryarchibald deleted the psg-636/device-man-fetch-data branch August 10, 2022 16:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@germain-gg germain-gg germain-gg approved these changes

@andybalaam andybalaam Awaiting requested review from andybalaam andybalaam is a code owner automatically assigned from matrix-org/element-web-reviewers

@duxovni duxovni Awaiting requested review from duxovni duxovni is a code owner automatically assigned from matrix-org/element-web-reviewers

@SimonBrandner SimonBrandner Awaiting requested review from SimonBrandner SimonBrandner is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kerryarchibald @germain-gg