This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 828
Support registration tokens #7275
Merged
Merged
Changes from 10 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
5b10be8
Support token authenticated registration
govynnus 39c258a
Backwards compatibility with unstable auth type
govynnus 8d3e1d9
Make LOGIN_TYPE public and readonly
govynnus 1ddf830
Update registration-tokens to latest develop
govynnus f9a3fe8
Remove line related to skinning
govynnus 47e3a7a
Change empty string to null
govynnus 3a30db6
Use "public"s for new code style
govynnus e76180e
Merge branch 'develop' into registration-tokens
govynnus 939a5ec
Change input to AccessibleButton
govynnus 6fa9204
Add more detail regarding source of token
govynnus 8e911d6
Merge remote-tracking branch 'upstream/develop' into registration-tokens
govynnus f489cd5
Fix lint error
govynnus 6cb3260
Change null back to ""
govynnus 3ebb998
Disable submit button when no token entered
govynnus a19b417
Add test for registration tokens
govynnus 73e0f8a
Merge remote-tracking branch 'upstream/develop' into registration-tokens
govynnus 43a3e4e
Merge remote-tracking branch 'upstream/develop' into registration-tokens
govynnus 1881fa5
Merge remote-tracking branch 'upstream/master' into registration-tokens
govynnus 04911e1
Merge remote-tracking branch 'upstream/develop' into registration-tokens
govynnus aea870d
Fix linting errors
govynnus 3636932
Fix test for registration tokens
govynnus a632da7
Merge remote-tracking branch 'upstream/develop' into registration-tokens
govynnus 3a944c0
Merge branch 'develop' into registration-tokens
andybalaam 284ba03
Add missing type
andybalaam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like the linter is complaining that the property doesn't exist - we might need to create an interstitial interface which extends
IAuthEntryProps
to use in theReact.Component<>
type instead.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
likewise with
continueText
belowThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, thanks for taking a look, I did notice that too when I updated it to develop and just remived those properties (don't know if that's OK?), but I forgot to push!