This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Switch ugly password boxes to Field or styled input #3071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
jryans
suggested changes
Jun 6, 2019
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
… t3chguy/authentication_password_field
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
jryans
approved these changes
Jun 19, 2019
turt2live
added a commit
that referenced
this pull request
Jul 10, 2019
The Field is controlled, so we should be using the state. Otherwise the value is undefined, which means we don't supply the required auth. Fixes element-hq/element-web#10302 Regressed in #3071
jryans
pushed a commit
that referenced
this pull request
Jul 11, 2019
The Field is controlled, so we should be using the state. Otherwise the value is undefined, which means we don't supply the required auth. Fixes element-hq/element-web#10302 Regressed in #3071
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes element-hq/element-web#4929
Usages for password fields of
<inputvs<Fieldis inconsistent throughout codebase, here it just felt nicer that on such a barren modal a Field is used IMO. If reviewer prefers I switch all over to Field then sure. Also removes a usage of a ref because they're discouraged in react in favour of controlled components.Signed-off-by: Michael Telatynski 7t3chguy@gmail.com