This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Send and undo reaction events #2954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If reactions are enabled, we need to enable client-side aggregation in the `MatrixClient` to access the data.
This displays existing reactions correctly in the action bar and reaction row, but it doesn't yet update after a new reaction is sent.
This updates the reaction state in the reaction row and action bar when a reaction is redacted. Part of element-hq/element-web#9574
This simplifies `ReactionDimension` by using the emoji string everywhere instead of keeping a separate text string as well. It should improve readability as well, as the reaction events also have a field `key` which was the emoji content, which was easy to confuse.
The `EventTile` for events without reactions now use `Event.relationsCreated` to listen for a future time where they come in to being.
The various reaction UI bits will now listen for `Reactions.add` for new reactions just like with redactions. Part of element-hq/element-web#9572
This updates both the reaction row and action bar UIs to send and redact reaction events as appropriate based on user interactions. Fixes element-hq/element-web#9574 Fixes element-hq/element-web#9572
This changes to "did update" and also calls the reaction change handler to ensure that we update the state of my reactions (to know which were sent by you).
turt2live
approved these changes
May 10, 2019
There was a problem hiding this comment.
overall lgtm pending matrix-org/matrix-js-sdk#911 being approved.
|
I've spent the last minute ogling the gif and trying to work out why it makes me slightly annoyed, and I think it's because the reactions pop in and move the button bar upwards. Is there any chance this could be fixed? Though I guess it's going to be a hard one :/ |
Hmm, we may want to do something about it. We'll see what other people think as well when it lands. |
This changes to use component state instead of `forceUpdate`, so that it's more obvious why an update is happening here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: Each commit in this PR is self-contained and has some additional context in the commit message, so you may want to review commit by commit.
Fixes element-hq/element-web#9572
Fixes element-hq/element-web#9574
Depends on matrix-org/matrix-js-sdk#911