Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Apply design to image thumbnails #2904

Closed
wants to merge 1 commit into from
Closed

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Apr 9, 2019

Border & rounded corners

element-hq/element-web#7565

@dbkr dbkr requested a review from a team April 9, 2019 17:11
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screenshots please :)

@dbkr
Copy link
Member Author

dbkr commented Apr 9, 2019

argh, having resized the window to take a screenshot I have just realised this doesn't work at all :(

@turt2live
Copy link
Member

I guess that means screenshots are now part of our official testing procedure

@turt2live
Copy link
Member

I'm curious as to what made this not work

@jryans
Copy link
Collaborator

jryans commented Mar 4, 2021

Thanks for making this contribution a while back. Since the code base has changed since this was opened, it no longer applies cleanly, and I don't think there's a need to keep it open in this state, as we can always find the code here again if needed. If you are still interested in pursuing this feature, please discuss with us in #element-dev:matrix.org to find a good approach forward.

@jryans jryans closed this Mar 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants