This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fix many thinkos in sorting the MemberList #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change ordering of memberlist to not try to compare lastActive of 'currentlyActive' users, as lastActive may will be a complete lie as it only gets updated when currentlyActive transitions to false (i think?) Remove order by online/idle/offline in favour of "currently active, ordered by power and then alphabetic name, followed by last active, followed by offline" Add commented-out code to track last-spoken-within-a-room ordering. Fix kludges due to SYJS-28 (depends on JS PR landing)
| unavailable: 2, | ||
| offline: 1 | ||
| }; | ||
| memberSort: function(now) { |
There was a problem hiding this comment.
does this actually need now? The relative ordering of users will be the same if you set now to a constant (say, zero), and it would save the extra layer of functions.
There was a problem hiding this comment.
it doesn't. i'm a crank. thanks.
|
Seems sane, modulo concerns about the sorting function. |
|
@richvdh PTAL |
| } | ||
| }, | ||
|
|
||
| // returns -1 if a < b. |
There was a problem hiding this comment.
nope, my brain is still melting. Please can this be "a comes before b".
There was a problem hiding this comment.
also, -1 and 1 are not guaranteed. prefer <0 and >0.
|
oooooops. final PTAL? |
|
lgtm |
richvdh
added a commit
that referenced
this pull request
Apr 19, 2016
Remove a spurious } which was introduced in PR #275
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on matrix-org/matrix-js-sdk#128