Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Align buttons in encrypted event dialog #2273

Merged
merged 1 commit into from
Nov 8, 2018

Conversation

jryans
Copy link
Collaborator

@jryans jryans commented Nov 8, 2018

Fixes element-hq/element-web#7642.

Signed-off-by: J. Ryan Stinnett jryans@gmail.com

Signed-off-by: J. Ryan Stinnett <jryans@gmail.com>
@jryans
Copy link
Collaborator Author

jryans commented Nov 8, 2018

Example dialogs with changes applied:

enc-event-info

unknown-devices

Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :D

@turt2live
Copy link
Member

(test failures unrelated)

@aaronraimist
Copy link
Contributor

This is much better, and it appears to be fixed in Chrome, but is still slightly off in Safari
screen shot 2018-11-08 at 11 50 43 am

@turt2live
Copy link
Member

I vote zooming out in Safari and taking away that guide :p

@jryans
Copy link
Collaborator Author

jryans commented Nov 8, 2018

still slightly off in Safari

Thanks for pointing that out! I'll see what I can do to keep all the browsers happy. 😁

@jryans
Copy link
Collaborator Author

jryans commented Nov 8, 2018

#2274 should take care of Safari as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants