Lazy loading: Lazy load members while backpaginating #2104

bwindels · 2018-08-02T15:12:39Z

Based of #2102, depends on matrix-org/matrix-js-sdk#676

Option is needed to send lazy loading filters to all endpoints used (like /messages)

Need to cleanup: Right now we pass both the option and the filter in, because startClient is not async. It would be nicer of the filter was created inside of MatrixClient somehow and we only had to pass in the option, not the filter.

This works with rooms which haven't had their members loaded yet.

…roes/counts.

Also, put comments in right order

As we need an option to turn lazy loading on (we can't just accept a filter, as /messages has an incompatible filter), better only pass the option and create the filter inside startClient

bwindels added 6 commits August 2, 2018 11:40

pass in userId with room in test

b9bbb7e

replace getMember(myId).membership with getMyMembership

908de56

This works with rooms which haven't had their members loaded yet.

Use room method to help with DM detection with fallback to summary he…

b151956

…roes/counts.

given the != join check, isInvite will never be true

802efc7

Also, put comments in right order

enable newly introduced option

4b96e01

support directional content in pill member fake

e184360

bwindels added the notready label Aug 2, 2018

bwindels mentioned this pull request Aug 2, 2018

Lazy loading: enable newly introduced option #2100

Closed

1 task

lampholder mentioned this pull request Aug 2, 2018

Lazy load member list element-hq/element-web#6611

Closed

22 tasks

bwindels added 2 commits August 2, 2018 19:38

Move LL filter creation inside MatrixClient

42fc83d

As we need an option to turn lazy loading on (we can't just accept a filter, as /messages has an incompatible filter), better only pass the option and create the filter inside startClient

fix lint

f1643f7

bwindels requested a review from a team August 2, 2018 17:58

bwindels removed the notready label Aug 2, 2018

bwindels changed the title ~~Lazy load members while backpaginating~~ Lazy loading: Lazy load members while backpaginating Aug 2, 2018

dbkr approved these changes Aug 3, 2018

View reviewed changes

bwindels merged commit 27ee85f into bwindels/feature_lazyloading Aug 3, 2018

bwindels deleted the bwindels/backpaginate_ll branch August 3, 2018 12:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Lazy loading: Lazy load members while backpaginating #2104

Lazy loading: Lazy load members while backpaginating #2104

bwindels commented Aug 2, 2018 •

edited

Loading

Lazy loading: Lazy load members while backpaginating #2104

Lazy loading: Lazy load members while backpaginating #2104

Conversation

bwindels commented Aug 2, 2018 • edited Loading

bwindels commented Aug 2, 2018 •

edited

Loading