This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Lazy load room members - Part I #2072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 tasks
|
Tests seem to fail for reasons unrelated to changes in this PR, or? |
dbkr
reviewed
Jul 24, 2018
There was a problem hiding this comment.
How will this behave with turning the feature flag on & off? Presumably when you turn it on, nothing will happen until you refresh, and even then not much will happen until you clear cache & reload?
How will it behave if you turn the feature flag off again? Do we need to force a new initial sync?
Instead call the method on the member that takes lazy loading into account
and that's ok because createRoom will already mark a DM as such on the inviter's side. So here we just handle the invitees side.
mainly for readability, but also to discourage grabbing into the member because of lazy loading changes
…le (due to lazy loading)
a6beab4 to
cfd20c7
Compare
|
@dbkr Good point about the switching behaviour. As discussed, I'll address it in a subsequent PR. |
|
Added the switching behaviour as a work item in the parent issue (element-hq/element-web#6611 (comment)) |
dbkr
approved these changes
Jul 26, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires matrix-org/matrix-js-sdk#667