This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fix image upload preview size #12607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and add a playwright test for it
|
@dbkr is this fixing a regression? what was it regressed by? links help for history |
|
Added, don't think it ever got a bug though. |
robintown
approved these changes
Jun 12, 2024
|
@dbkr given the regression is in the RC do we want to backport this change? |
RiotRobot
pushed a commit
that referenced
this pull request
Jun 13, 2024
* Fix image upload preview size and add a playwright test for it * Add the actual playwright test (cherry picked from commit 25e4515)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and add a playwright test for it
Regressed by #12591
Checklist
public/exportedsymbols have accurate TSDoc documentation.