This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fix flaky jest tests #12486
Merged
Fix flaky jest tests #12486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...and remove the code that causes them to be retried in CI. Most of these were just lack of waiting for async things to happen, mostly lazy loading components, hence whythey worked on the retry: because the code had been loaded by then.
richvdh
reviewed
May 2, 2024
Comment on lines
+200
to
+202
| waitFor(() => { | ||
| expect(SdkContextClass.instance.roomViewStore.getThreadId()).toBe(rootEvent.getId()); | ||
| }); |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and remove the code that causes them to be retried in CI. Most of these were just lack of waiting for async things to happen, mostly lazy loading components, hence why they worked on the retry: because the code had been loaded by then.
The highlight here is a test where the expectation was updated in the move to react testing library such that it asserted that the thing had not worked (which it hadn't because we didn't await on the keyboard input). The next test then caught the keyboard input and ended up with text in filter box when it shouldn't have, causing it to fail. It's somewhat shocking that the failure mode of missing an await on keyboard input is so horrendous and non-obvious.
Checklist
public/exportedsymbols have accurate TSDoc documentation.