Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Add caption for empty TAC #12226

Merged
merged 3 commits into from
Feb 6, 2024

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Feb 5, 2024

Fixes: https://github.com/element-hq/wat-internal/issues/146

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Here's what your changelog entry will look like:

🐛 Bug Fixes

  • Add caption for empty TAC (#12226). Fixes element-hq/wat-internal#146.

@dbkr dbkr added the T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems label Feb 5, 2024
@dbkr dbkr requested a review from a team as a code owner February 5, 2024 14:51
@dbkr dbkr requested review from florianduros and MidhunSureshR and removed request for a team February 5, 2024 14:51
Copy link
Contributor

@florianduros florianduros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

Can we have a small unit test for this case?

@@ -3120,6 +3120,9 @@
"empty": "You don't currently have any stickerpacks enabled",
"empty_add_prompt": "Add some now"
},
"tac": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A threads_activity_centre category is available in the lang json

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, thanks

@dbkr dbkr merged commit f63abc3 into florianduros/threads/pop-out-panel Feb 6, 2024
19 checks passed
@dbkr dbkr deleted the dbkr/tac_empty_caption branch February 6, 2024 11:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants