Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Add test for the ThreadsActivityCentre component #12207

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Add test for the ThreadsActivityCentre component #12207

merged 2 commits into from
Feb 2, 2024

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Feb 1, 2024 •
edited by github-actions bot
Loading

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@dbkr dbkr requested a review from a team as a code owner February 1, 2024 18:23
@dbkr dbkr requested review from florianduros and MidhunSureshR and removed request for a team February 1, 2024 18:23
@dbkr dbkr added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Feb 1, 2024
florianduros
florianduros reviewed Feb 2, 2024
View reviewed changes
Copy link
Contributor

@florianduros florianduros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good!

What do you think about to add jest snapshot to the test?

@dbkr
Copy link
Member Author

dbkr commented Feb 2, 2024

Yeah, I guess there's no reason not to add a snapshot

@dbkr dbkr merged commit f9608c0 into florianduros/threads/pop-out-panel Feb 2, 2024
19 checks passed
@dbkr dbkr deleted the dbkr/tac_test branch February 2, 2024 12:53
@florianduros florianduros mentioned this pull request Feb 7, 2024
Merged
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@florianduros florianduros florianduros approved these changes

@MidhunSureshR MidhunSureshR Awaiting requested review from MidhunSureshR MidhunSureshR was automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbkr @florianduros