Fix peeked rooms showing up in historical (#11316)

matrix-org · Jul 25, 2023 · c57a4cb · c57a4cb
1 parent b5cbd9e
commit c57a4cb
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/stores/room-list/algorithms/Algorithm.ts b/src/stores/room-list/algorithms/Algorithm.ts
@@ -548,6 +548,8 @@ export class Algorithm extends EventEmitter {
         const tags: TagID[] = [];
 
         const membership = getEffectiveMembership(room.getMyMembership());
+        if (!membership) return []; // peeked room has no tags
+
         if (membership === EffectiveMembership.Invite) {
             tags.push(DefaultTagID.Invite);
         } else if (membership === EffectiveMembership.Leave) {

diff --git a/src/utils/membership.ts b/src/utils/membership.ts
@@ -56,7 +56,11 @@ export function splitRoomsByMembership(rooms: Room[]): MembershipSplit {
     };
 
     for (const room of rooms) {
-        split[getEffectiveMembership(room.getMyMembership())].push(room);
+        const membership = room.getMyMembership();
+        // Filter out falsey relationship as this will be peeked rooms
+        if (!!membership) {
+            split[getEffectiveMembership(membership)].push(room);
+        }
     }
 
     return split;