Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block read marker and read receipt from advancing into pending events #981

Merged
merged 2 commits into from
Jul 5, 2019

Conversation

jryans
Copy link
Collaborator

@jryans jryans commented Jul 5, 2019

This changes the methods that update the read marker and read receipts to
prevent advancing into pending events.

Part of element-hq/element-web#9952

This changes the methods that update the read marker and read receipts to
prevent advancing into pending events.

Part of element-hq/element-web#9952
@jryans jryans requested a review from a team July 5, 2019 13:42
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally lgtm

src/client.js Show resolved Hide resolved
src/client.js Show resolved Hide resolved
src/client.js Show resolved Hide resolved
src/models/room.js Show resolved Hide resolved
@jryans jryans merged commit 60e339b into develop Jul 5, 2019
@t3chguy t3chguy deleted the jryans/reactions-send-marks-unread branch May 10, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants