Broaden spec version support #4014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit does two things: * It puts the "minimum supported matrix version" from v1.5 back down to v1.1. In other words, it is a partial revert of #3970. (Partial, because we don't need to update the tests.) We're doing this largely because #3970 was introduced without a suitable announcement and deprecation policy. We haven't yet decided if the js-sdk's spec support policy needs to change, or if we will re-introduce this change in future in a more graceful manner. * It increases the "maximum supported matrix version" from v1.5 up to v1.9. Previously, the two concepts were tied together, but as discussed at length in #3915 (comment), this is incorrect. Unfortunately, we have no real way of testing whether it is true that the js-sdk actually works with a server which supports *only* v1.9, but as per the comment above, we can't do much about that. Fixes #3915.
richvdh
added a commit
to matrix-org/matrix-react-sdk
that referenced
this pull request
Jan 18, 2024
Something of a compainion to matrix-org/matrix-js-sdk#4014, but also covering the issues discussed at matrix-org/matrix-js-sdk#3915 (comment). In short: we should not reject servers which only implement recent versions of the spec. Doing so holds back the ecosystem by requiring all new servers to implement features that nobody actually uses any more.
t3chguy
approved these changes
Jan 18, 2024
RiotRobot
pushed a commit
that referenced
this pull request
Jan 18, 2024
This commit does two things: * It puts the "minimum supported matrix version" from v1.5 back down to v1.1. In other words, it is a partial revert of #3970. (Partial, because we don't need to update the tests.) We're doing this largely because #3970 was introduced without a suitable announcement and deprecation policy. We haven't yet decided if the js-sdk's spec support policy needs to change, or if we will re-introduce this change in future in a more graceful manner. * It increases the "maximum supported matrix version" from v1.5 up to v1.9. Previously, the two concepts were tied together, but as discussed at length in #3915 (comment), this is incorrect. Unfortunately, we have no real way of testing whether it is true that the js-sdk actually works with a server which supports *only* v1.9, but as per the comment above, we can't do much about that. Fixes #3915. (cherry picked from commit c885542)
github-merge-queue bot
pushed a commit
to matrix-org/matrix-react-sdk
that referenced
this pull request
Jan 19, 2024
Something of a compainion to matrix-org/matrix-js-sdk#4014, but also covering the issues discussed at matrix-org/matrix-js-sdk#3915 (comment). In short: we should not reject servers which only implement recent versions of the spec. Doing so holds back the ecosystem by requiring all new servers to implement features that nobody actually uses any more.
RiotRobot
pushed a commit
to matrix-org/matrix-react-sdk
that referenced
this pull request
Jan 19, 2024
Something of a compainion to matrix-org/matrix-js-sdk#4014, but also covering the issues discussed at matrix-org/matrix-js-sdk#3915 (comment). In short: we should not reject servers which only implement recent versions of the spec. Doing so holds back the ecosystem by requiring all new servers to implement features that nobody actually uses any more. (cherry picked from commit a8cc6cc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
It puts the "minimum supported matrix version" from v1.5 back down to v1.1. In other words, it is a partial revert of Bump minimum spec version to v1.5 #3970. (Partial, because we don't need to update the tests.)
We're doing this largely because Bump minimum spec version to v1.5 #3970 was introduced without a suitable announcement and deprecation policy. We haven't yet decided if the js-sdk's spec support policy needs to change, or if we will re-introduce this change in future in a more graceful manner.
It increases the "maximum supported matrix version" from v1.5 up to v1.9. Previously, the two concepts were tied together, but as discussed at length in Check for version is not allowing newer versions than the minimum version #3915 (comment), this is incorrect.
Unfortunately, we have no real way of testing whether it is true that the js-sdk actually works with a server which supports only v1.9, but as per the comment above, we can't do much about that.
Fixes #3915.
Here's what your changelog entry will look like:
✨ Features