Enable TypeScript declaration maps #1966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows go-to-definition to reach the original .ts files for consumers of the package. It emits .d.ts.map files alongside the regular .d.ts files e.g. in sdk.createClient go-to-definition on createClient will place the cursor at the function in src/matrix.ts rather than inside a definition file lib/matrix.d.ts Signed-off-by: Alex Macleod <alex@macleod.io>
turt2live
approved these changes
Oct 5, 2021
su-ex
added a commit
to SchildiChat/matrix-js-sdk
that referenced
this pull request
Oct 25, 2021
* Use `ICallFeedOpts` in the `CallFeed` constructor. To construct a new `CallFeed` object you have to pass `ICallFeedOpts` e.g. `const callFeed = new CallFeed({client ([\matrix-org#1964](matrix-org#1964)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Make threads use 'm.thread' relation ([\matrix-org#1980](matrix-org#1980)).
* Try to answer a call without video if we can't access the camera ([\matrix-org#1972](matrix-org#1972)). Fixes element-hq/element-web#17975 and element-hq/element-web#17975. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Make `opts` in `importRoomKeys()` optional ([\matrix-org#1974](matrix-org#1974)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Enable TypeScript declaration maps ([\matrix-org#1966](matrix-org#1966)). Contributed by [Alexendoo](https://github.com/Alexendoo).
* Fix `requestVerificationDM` with chronological `pendingEventOrdering` ([\matrix-org#1943](matrix-org#1943)). Contributed by [freaktechnik](https://github.com/freaktechnik).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows go-to-definition to reach the original .ts files for consumers of the package. It emits .d.ts.map files alongside the regular .d.ts files
e.g. in sdk.createClient go-to-definition on createClient will place the cursor at the function in src/matrix.ts rather than inside a definition file lib/matrix.d.ts
Here's what your changelog entry will look like:
✨ Features