Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change sharedHistory flag to unstable variant #1449

Merged
merged 3 commits into from
Apr 29, 2022
Merged

Conversation

Anderas
Copy link
Contributor

@Anderas Anderas commented Apr 28, 2022

Resolves element-hq/element-ios#4947 which is an implementation of matrix-org/matrix-spec-proposals#3061

Handle several edge cases when key sharing:

  • use unstable parameter name of shared_history when exporting and importing keys. This makes it compatible with the existing web implementation (e.g. backup keys on the web and restore on iOS => preserve sharedHistory flag)
  • add integration tests for key sharing across several devices
  • ensure that keys are only shared if the roomId of the session matches the room a user is invited into

@Anderas Anderas requested review from a team, aringenbach and BillCarsonFr and removed request for a team April 28, 2022 10:32
Copy link
Contributor

@aringenbach aringenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM (would be awesome to write new tests in Swift if possible though)

MatrixSDKTests/MXCryptoShareTests.m Outdated Show resolved Hide resolved
Co-authored-by: aringenbach <80891108+aringenbach@users.noreply.github.com>
@Anderas
Copy link
Contributor Author

Anderas commented Apr 29, 2022

Code LGTM (would be awesome to write new tests in Swift if possible though)

Yea in this case I wanted to write the integration tests consistently with the rest of the CryptoSharingTests, but should start switching over to Swift there as well.

@Anderas Anderas merged commit a389ff9 into develop Apr 29, 2022
@Anderas Anderas deleted the andy/4947_sharing_flags branch April 29, 2022 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sharing room keys for past messages
2 participants