-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for native e2ee #299
Conversation
Currently blocked on turt2live/matrix-bot-sdk#208 |
The I tried to rebase this PR onto The Hookshot Bot can decrypt messages I send him, but Element can't decrypt messages send by the bot ( I'm not sure why this happens, but a very simple bot using the My current guess is that the For easier testing I created a @Half-Shot Can you please have a look at the problem? I'm not too familiar with the Matrix API's / SDK's. |
Wow, thanks for looking into this. I'll be sure to take a look at your changes and see if I can get a working decryption going. |
I could track down the decryption issue to users not being tracked properly in the Up next is some general testing of the bot encryption. |
#417 lands support for bot-sdk 0.6.1 which means we can lean on that for some of this PR. turt2live/matrix-bot-sdk#251 is gonna be a hard requirement though, given how hookshot is used. |
It seems like SDK dependencies have landed so this should be mergeable ? |
ac761ba
to
18d41f0
Compare
This works, and adds some docs to explain the extra configuration steps needed to get this working (namely Synapse experimental configs). However, bridge startup sometimes fails with |
The The only remaining issue is that "greeting" messages sent by the bot may fail to be decryptable (and appear in Element Web with an error of |
6099f36
to
763183f
Compare
Lastest push just rebases onto the tip of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️ even though I can't review my own stuff!
fe1f982
to
860398a
Compare
Changes made by the latest force-push:
Note that there remain some issues that can only be fixed in
|
This also enables encryption for new admin rooms when appropriate.
- Add comment to clarify Redis (the `queue` section) must be configured in order for encryption to work - Mention that the `encryption` section is optional, and omitting it will disable encryption support
- Mention that worker mode isn't supported with encryption yet - Mention removal of Pantalaimon-based encryption
This is required to safely enable encryption for the bots that post GenericHook messages.
Same as a9e6e11 but for the sub-bots that post GenericHook messages.
This refreshes the list of known rooms for crypto events.
860398a
to
df5e4d8
Compare
Changes made by the latest (and hopefully last!) force-push:
|
This PR adds support for native e2ee within the bridge, and drops support for Pantalaimon based bridging.
N.B this doesn't work yet, seeing failures like: