This repository has been archived by the owner on Nov 25, 2024. It is now read-only.
Add internal API QueryMembershipForUser #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anant Prakash <anantprakashjsr@gmail.com>
8ae57dd to
c90e528
Compare
APwhitehat
commented
Jul 10, 2018
| // ID of the room to fetch membership from | ||
| RoomID string `json:"room_id"` | ||
| // ID of the user sending the request | ||
| Sender string `json:"sender"` |
There was a problem hiding this comment.
Should this be changed from sender to UserID ?
since we want the membership for this user and not the sender.
@erikjohnston
erikjohnston
approved these changes
Jul 11, 2018
| // ID of the room to fetch membership from | ||
| RoomID string `json:"room_id"` | ||
| // ID of the user sending the request | ||
| Sender string `json:"sender"` |
|
merged on prior approval :P #544 (review) |
anoadragon453
pushed a commit
that referenced
this pull request
Jul 16, 2018
* Add internal API QueryMembershipForUser Signed-off-by: Anant Prakash <anantprakashjsr@gmail.com> * Change sender to user_id
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lightweight API to check membership for an user in a room.