-
-
Notifications
You must be signed in to change notification settings - Fork 678
[federation] Add user_devices query #498
[federation] Add user_devices query #498
Conversation
if err != nil { | ||
return util.JSONResponse{ | ||
Code: http.StatusBadRequest, | ||
JSON: jsonerror.InvalidArgumentValue("Invalid userID"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we usually write "user ID" in external responses.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Force of habit. Thanks for pointing out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Is this endpoint currently unspecced?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good start for the user device APIs. We'll need to implement the streaming of device changes to remote servers and things (I've commented on #493) at some point too
Skipping
stream_id
since we are not using it in Dendrite.Signed-off-by: Anant Prakash <anantprakashjsr@gmail.com>