Skip to content
This repository has been archived by the owner on Nov 25, 2024. It is now read-only.

[federation] Add user_devices query #498

Merged
merged 2 commits into from
Jun 26, 2018

Conversation

APwhitehat
Copy link
Contributor

@APwhitehat APwhitehat commented Jun 12, 2018

Skipping stream_id since we are not using it in Dendrite.

Signed-off-by: Anant Prakash <anantprakashjsr@gmail.com>

if err != nil {
return util.JSONResponse{
Code: http.StatusBadRequest,
JSON: jsonerror.InvalidArgumentValue("Invalid userID"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we usually write "user ID" in external responses.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Force of habit. Thanks for pointing out.

Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Is this endpoint currently unspecced?

Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good start for the user device APIs. We'll need to implement the streaming of device changes to remote servers and things (I've commented on #493) at some point too

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants