This repository has been archived by the owner on Nov 25, 2024. It is now read-only.
[federation] Implement state APIs #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| // getEvent returns the requested event. | ||
| // Or returns an error response which can be sent to the client. |
There was a problem hiding this comment.
"returns the requested event, otherwise it returns"
| @@ -45,11 +61,13 @@ func GetEvent( | |||
| &authResponse, | |||
| ) | |||
| if err != nil { | |||
| return util.ErrorResponse(err) | |||
| resErr := util.ErrorResponse(err) | |||
There was a problem hiding this comment.
These could also just be
return nil, &util.ErrorResponse(err)
There was a problem hiding this comment.
I couldn't believe it either. That is not allowed in go.
|
At some point we should make it so that |
erikjohnston
approved these changes
Jun 22, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #485.
Other TODOs (will create gh issues to track): Figure out how & when to use keyring to verify JSON requests.
event_authcan be implemented via the state apis, but is it too much of extra work ?Signed-off-by: Anant Prakash <anantprakashjsr@gmail.com>