This repository has been archived by the owner on Nov 25, 2024. It is now read-only.
Auto-generate username if none provided during registration #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anoadragon453
suggested changes
May 29, 2018
| @@ -403,6 +406,18 @@ func Register( | |||
| sessionID = util.RandomString(sessionIDLength) | |||
| } | |||
|
|
|||
| // Don't allow numeric username. But it's impractical to reserve numerics outside the range of int. | |||
There was a problem hiding this comment.
"numeric username" -> "numeric usernames"
Also do you mean by "it's impractical to reserve numerics outside the range of int"? Just that we don't need to worry about > MaxInt?
| JSON: jsonerror.InvalidUsername("Numeric user IDs are reserved"), | ||
| } | ||
| } | ||
| // auto generate a numeric username if r.Username is empty |
b478f4b to
1f668b3
Compare
anoadragon453
suggested changes
May 31, 2018
| sessionID = util.RandomString(sessionIDLength) | ||
| } | ||
|
|
||
| // Don't allow numeric usernames less than MAX_INT64. |
There was a problem hiding this comment.
No ?
We are using numbers less than int_max 64, so only disallow numbers less than the same.
There was a problem hiding this comment.
Ah, for users trying to register a username. Thought this was referencing generated usernames.
| if r.Username == "" { | ||
| id, err := accountDB.GetNewNumericLocalpart(req.Context()) | ||
| if err != nil { | ||
| return jsonerror.InternalServerError() |
There was a problem hiding this comment.
We use return httputil.LogThenError(req, err) so that it includes an appropriate error message in the response.
anoadragon453
approved these changes
May 31, 2018
|
@APwhitehat Could you rebase on master please? |
|
aye aye edit: Sorry, I have a habit of rebasing instead of merge. :P |
b3ec18b to
91587ee
Compare
This was referenced Oct 30, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto-generate username if none provided during registration.
Reserve numeric user IDs.
fixes #400.
Signed-off-by: Anant Prakash <anantprakashjsr@gmail.com>