This repository has been archived by the owner on Nov 25, 2024. It is now read-only.
Add token generation using go macaroon #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anant Prakash <anantprakashjsr@gmail.com>
Signed-off-by: Anant Prakash <anantprakashjsr@gmail.com>
32e9ea7 to
bb5863e
Compare
|
Warning: |
anoadragon453
suggested changes
May 22, 2018
| const ( | ||
| macaroonVersion = macaroon.V2 | ||
| defaultDuration = 2 * 60 | ||
| // UserPrefix is common prefix for every user_id caveat |
There was a problem hiding this comment.
"is common prefix" -> "is a common prefix"
| defaultDuration = 2 * 60 | ||
| // UserPrefix is common prefix for every user_id caveat | ||
| UserPrefix = "user_id = " | ||
| // TimePrefix is common prefix for every expiry caveat |
There was a problem hiding this comment.
"is common prefix" -> "is a common prefix"
| } | ||
|
|
||
| // serializeMacaroon takes a macaroon to be serialized. | ||
| // returns it's base64 encoded string, URL safe, which can be sent via web, email, etc. |
There was a problem hiding this comment.
"returns it's" -> "returns its"
|
Merging with dead code. |
anoadragon453
added a commit
that referenced
this pull request
May 22, 2018
This reverts commit afeab7b.
anoadragon453
added a commit
that referenced
this pull request
May 22, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only the second commit is of interest.
1st commit is just the result of
gb vendor fetch -tag v2.0.0 github.com/go-macaroon/macaroon.This was earlier part of #429