This repository has been archived by the owner on Nov 25, 2024. It is now read-only.
Implement transactions cache to ensure idempotency of sendEvents #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anant Prakash <anantprakashjsr@gmail.com>
Signed-off-by: Anant Prakash <anantprakashjsr@gmail.com>
78e8e16 to
11c11a4
Compare
krombel
reviewed
May 10, 2018
|
|
||
| if txnID != nil { | ||
| // Try to fetch response from transactionsCache | ||
| res, err := transactionsCache.FetchTransaction(*txnID) |
There was a problem hiding this comment.
You made sure that there is a correlation to txnID so this should work but as you get a pointer of transactionsCache so I would add a null guard before accessing it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #327 .
This implements transactions cache, which is used to ensure idempotency of clientapi:
/rooms/{roomID}/send/{eventType}/{txnID}.This can be extended as required to other events with txnID.
@erikjohnston: How to proceed further ?