This repository has been archived by the owner on Nov 25, 2024. It is now read-only.
Fix state resets #3231
Merged
Fix state resets #3231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S7evinK
commented
Oct 6, 2023
| @@ -300,7 +300,7 @@ func updateProfile( | |||
| }, e | |||
| } | |||
|
|
|||
| if err := api.SendEvents(ctx, rsAPI, api.KindNew, events, device.UserDomain(), domain, domain, nil, true); err != nil { | |||
| if err := api.SendEvents(ctx, rsAPI, api.KindNew, events, device.UserDomain(), domain, domain, nil, false); err != nil { | |||
There was a problem hiding this comment.
This slows down changing profiles, but makes sure that all events have been sent to the roomserver.
This is needed, as e.g. bridges may change the avatar and displayname in short succession.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3231 +/- ##
==========================================
- Coverage 65.99% 65.18% -0.82%
==========================================
Files 507 507
Lines 57155 57174 +19
==========================================
- Hits 37718 37267 -451
- Misses 15656 16009 +353
- Partials 3781 3898 +117
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
devonh
approved these changes
Oct 19, 2023
… into s7evink/state-resets
danpe
pushed a commit
to globekeeper/dendrite
that referenced
this pull request
Oct 30, 2023
This was referenced Nov 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs matrix-org/gomatrixserverlib#419
May fix: #2508, #1760