This repository has been archived by the owner on Nov 25, 2024. It is now read-only.
3PID invite exchange over federation #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return nil, nil | ||
| // Use federation to auth the event | ||
| var remoteServer gomatrixserverlib.ServerName | ||
| _, remoteServer, err = gomatrixserverlib.SplitID('!', inv.RoomID) |
There was a problem hiding this comment.
I think synapse also falls back to the server who sent the "m.room.third_party_invite" by using the user ID of the sender of the invite, or am I imagining things?
There was a problem hiding this comment.
Actually it first checks on the sender's server and then the room's server. Fixed in 0e356e2
| return nil, nil | ||
| // Use federation to auth the event | ||
| var remoteServers []gomatrixserverlib.ServerName | ||
| _, remoteServers[0], err = gomatrixserverlib.SplitID('@', inv.Sender) |
There was a problem hiding this comment.
This will have problems because the remoteServers slice will have length 0.
remoteServers := make([]gomatrixserverlib.ServerName, 2)might be better here.
There was a problem hiding this comment.
Indeed. Fixed in ebe91ac
| continue | ||
| } | ||
|
|
||
| err = federation.ExchangeThirdPartyInvite(server, *builder) |
There was a problem hiding this comment.
If there is an error you may want to continue and try the next server.
There was a problem hiding this comment.
Fixed in e1c8861
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows matrix-org/gomatrixserverlib#61
This PR address the case where the server receives a 3PID invite from an identity server for a room it's not in. It will then send to the room's server all the necessary data for building a
m.room.memberevent so the room's server can authenticate it.