Add Must[Get|Set]DisplayName and use MustUploadKeys in more places #755
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small refactor to add a few more helpers. The hitlist for this can be discovered using
grep --only-matching -Er '\[\]string\{\"_matrix\".*\}' tests | grep -E --only-matching '\[\]string.*' | sort | uniq -c | sort
which currently spits out:The point of helpers in the
CSAPI
struct is:Originally we didn't have enough tests to meet that 2nd bullet point but this hasn't been true for quite some time, but we never revisited adding helpers until now.