Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test the updated MSC2946 room hierarchy endpoint. #187

Merged
merged 4 commits into from
Aug 10, 2021

Conversation

clokep
Copy link
Member

@clokep clokep commented Aug 6, 2021

This adds tests for matrix-org/synapse#10549.

I opted to not remove the old tests for now since both endpoints are going to exist in conjunction right now. We should remoe those in the future when removing support for the old endpoint.

@clokep clokep force-pushed the clokep/spaces-pagination branch from 6943f26 to c359e5a Compare August 9, 2021 13:59
@clokep clokep requested a review from a team August 9, 2021 15:31
@clokep clokep marked this pull request as ready for review August 9, 2021 17:12
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Only thing I'd suggest is adding comments next to the old /rooms/{room}/spaces tests to say that they are due for removal.

@clokep clokep force-pushed the clokep/spaces-pagination branch from 5071ca2 to 7d40874 Compare August 10, 2021 16:56
@clokep clokep merged commit 2574030 into master Aug 10, 2021
@clokep clokep deleted the clokep/spaces-pagination branch August 10, 2021 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants