Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add staking module README #1082

Merged
merged 6 commits into from
Oct 18, 2023
Merged

Add staking module README #1082

merged 6 commits into from
Oct 18, 2023

Conversation

Raneet10
Copy link
Member

Description

This PR adds README for staking module and fixes a few typos.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai
  • I have created new e2e tests into express-cli

@Raneet10 Raneet10 requested review from marcello33, 0xKrishna and a team October 12, 2023 13:09
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

All modified lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

marcello33
marcello33 reviewed Oct 12, 2023
View reviewed changes
staking/README.md Outdated Show resolved Hide resolved
staking/README.md Outdated Show resolved Hide resolved
staking/README.md Outdated Show resolved Hide resolved
staking/README.md Outdated Show resolved Hide resolved
staking/README.md Outdated Show resolved Hide resolved
staking/README.md Outdated Show resolved Hide resolved
staking/README.md Outdated Show resolved Hide resolved
staking/README.md Outdated Show resolved Hide resolved
staking/README.md Outdated Show resolved Hide resolved
staking/README.md Outdated Show resolved Hide resolved
@Raneet10 Raneet10 merged commit 62879ac into develop Oct 18, 2023
@Raneet10 Raneet10 deleted the raneet10/pos-1830 branch October 18, 2023 03:31
@Raneet10 Raneet10 mentioned this pull request Oct 18, 2023
Merged
14 tasks
Raneet10 added a commit that referenced this pull request Feb 13, 2024
@Raneet10
Add staking module README (#1082)
c17877f 
* staking: init README

* staking: fix README and typos

* staking: address comments

* staking: fix table of contents

* staking: format tx instructions as sub section

* staking: refactor query commands section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xKrishna 0xKrishna 0xKrishna approved these changes

@marcello33 marcello33 marcello33 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Raneet10 @marcello33 @0xKrishna