ethclient: use bor_getRootHash
instead of eth namespace
#967
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bor is flexible enough to also reply to the call
eth_getRootHash
even though it belongs tobor
namespace. Hence, the eth client used to calleth_getRootHash
instead ofbor_getRootHash
and it's being used in heimdall for checkpoints. This works for bor and heimdall but causes issue in erigon because when heimdall asks an erigon node for the root hash, it responds withmethod not available
error as this method lies in thebor
namespace in erigon rpc. This PR fixes it by just calling thebor
namespace instead ofeth
so that heimdall can also communicate with erigon.Will also raise a PR in heimdall to use this version of bor.
Changes
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Nodes audience
In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)
Checklist
Cross repository changes
Testing
Manual tests
Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it
Additional comments
Please post additional comments in this section if you have them, otherwise delete it